src: remove INT_MAX asserts in SecretKeyGenTraits #48053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that CSPRNG() does not silently fail when the length exceeds INT_MAX anymore, there is no need for the two relevant assertions in SecretKeyGenTraits anymore. Refs: nodejs#47515
|
Review requested:
|
nodejs-github-bot
added
c++
lpinca
approved these changes
May 20, 2023
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
added
the
author ready
19 tasks
panva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
This comment was marked as off-topic.
This comment was marked as off-topic.
panva
approved these changes
May 24, 2023
panva
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c3b84f1 |
This was referenced May 25, 2023
22 tasks
danielleadams
added
the
backport-requested-v18.x
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Now that CSPRNG() does not silently fail when the length exceeds INT_MAX anymore, there is no need for the two relevant assertions in SecretKeyGenTraits anymore. Refs: nodejs#47515 PR-URL: nodejs#48053 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Now that CSPRNG() does not silently fail when the length exceeds INT_MAX anymore, there is no need for the two relevant assertions in SecretKeyGenTraits anymore. Refs: nodejs#47515 PR-URL: nodejs#48053 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
CSPRNG()does not silently fail when the length exceedsINT_MAXanymore, there is no need for the two relevant assertions inSecretKeyGenTraitsanymore.Refs: #47515